Delete unused and broken LatLngBounds.pad() method. #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method fails to deal correctly with LatLng wrap arounds. A more
correct version would probably look more like:
void pad(double bufferRatio) {
final heightBuffer = (_sw!.latitude - _ne!.latitude).abs() * bufferRatio;
final widthBuffer = (_sw!.longitude - _ne!.longitude).abs() * bufferRatio;
final point1 = LatLng((90 + _sw!.latitude - heightBuffer) % 180 - 90,
(180 + _sw!.longitude - widthBuffer) % 360 - 180);
final point2 = LatLng((90 + _ne!.latitude + heightBuffer) % 180 - 90,
(180 + _ne!.longitude + widthBuffer) % 360 - 180);
final newBounds = LatLngBounds(point1, point2);
_sw = newBounds.southWest;
_ne = newBounds.northEast;
}
On a tangent, it probably should be a factory rather than a mutable
method and the `bufferRatio` parameter is hard to use correctly. For
example, bufferRatio = 0.5 would increase the bounds to 4 times its
original size.
|
Any thoughts on deleting already broken code? |
|
Hey @ignatz, sorry for the massive delay. I'll take a look tommorrow. |
JaffaKetchup
approved these changes
Feb 5, 2023
|
Thanks for the contribution :) |
|
Thanks for the contribution! |
|
Naively, grab above version and provide it as a function or extension on latlngbounds |
adamhb123
pushed a commit
to adamhb123/flutter_map
that referenced
this pull request
Sep 13, 2024
A similar method of the same name was removed in fleaflet#1427. This method simply expands the LatLngBounds coordinates by latitude and longitude constants. Checks to ensure the adjustment remains "in-bounds" is performed, similar to the extend and extendBounds methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method fails to deal correctly with LatLng wrap arounds. A more correct version would probably look more like:
On a tangent, it probably should be a factory rather than a mutable method and the
bufferRatioparameter is hard to use correctly. For example, bufferRatio = 0.5 would increase the bounds to 4 times its original size.